Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Google App Engine (Python) 1.9.23 => 1.9.26 #44452

Closed
wants to merge 2 commits into from

Conversation

brianmhunt
Copy link

No description provided.

@dunn
Copy link
Contributor

dunn commented Sep 30, 2015

Any chance of a test while you're at it? Just something that checks basic functionality would be great.

@brianmhunt
Copy link
Author

@dunn I would certainly enjoy writing a test but I've never written in Ruby before, and am not sure how homebrew does its testing.

That said, a basic test might be along the lines of:

$ env PYTHONPATH=/usr/local/share/google-app-engine python -m
  google.appengine.base.capabilities_pb

(where base.capabilities_pb is just an arbitrary python module in AppEngine). This'll exit with a non-zero status code when app-engine is (basically) not working (in the sense that the builtin Python cannot include it).

@dunn
Copy link
Contributor

dunn commented Oct 3, 2015

This is how you'd write that:

  test do
    ENV["PYTHONPATH"] = pkgshare
    system "python", "-m", "google.appengine.base.capabilities_pb"
  end

But when I run it I get /usr/local/opt/python/bin/python2.7: No module named appengine.base.

@brianmhunt
Copy link
Author

Thanks @dunn

I'm not sure what the pkgshare value is, but when I explicitly set the environment to PYTHONPATH=/usr/local/Cellar/app-engine-python/1.9.23/share/google-app-engine then the exit code is 0 when I try it.

What is the pkgshare value?

@dunn
Copy link
Contributor

dunn commented Oct 3, 2015

The value of pkgshare is /usr/local/Cellar/app-engine-python/1.9.23/share/app-engine-python. When I installed this formula I didn't have a directory in share called google-app-engine, just app-engine-python.

@brianmhunt
Copy link
Author

Perhaps the discrepancy is because I upgraded from the prior google-app-engine formula (per the renames)?

In any case, there should definitely be some sort of symlink e.g. /usr/local/share/google-app-engine/usr/local/Cellar/app-engine-python/{{ VERSION e.g. 1.9.26 }}/share/google-app-engine

When that symlinking exists, exporting that as the PYTHONPATH and running the python -m test should work as expected. Sorry I cannot offer a PR but I can only guess how Ruby/formula would properly do the symlink.

@bfontaine
Copy link
Contributor

This PR needs to be rebased on top of master.

@bfontaine
Copy link
Contributor

Ping?

@bfontaine
Copy link
Contributor

Closing due to no response. Feel free to open another PR addressing the comments above. Thanks!

@bfontaine bfontaine closed this Dec 28, 2015
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants